Jacob Rief

Results 514 comments of Jacob Rief

@eagle21st I get your point and indeed ws4redis is not very flexible in this sense. Do you handle user authentication though a middleware class, such as `django.contrib.auth.middleware.AuthenticationMiddleware`? Currently the user...

From the point of view of a (good) Django developer, wouldn't it be better to implement it similar to `django.contrib.auth.middleware.AuthenticationMiddleware`? Having a well known and supported middleware class for authentication...

I know, I should remove the Python-2 compatibility layer 🤔

You should add the permission checks to the Django-Loop and then store them in Redis. This has some benefits: a) they expire themselves b) in the WS-loop you look up...

Could you please create a PR for how to fix it. I'm currently still on django-cms==3.3.2

A few hours a released django-shop 0.9.2 It is shipped with 5 examples which run out of the box. Please check tutorial/quickstart for a better explanation. Use one of them...

This feature is really requested, see #29, #70 and #43. If I have some time, I'll try to implement this.

please rebase your pull request

what does the `value`-tuple actually contain? Wouldn't it be safer to check for `if len(value) > 2`?

As I wrote in another issue, this `websocket.py` file was pilfered from another project. It currently is the only part, which I was unable to port to Python-3.3, see https://bitbucket.org/Jeffrey/gevent-websocket/issue/54/python-3-support...