Josh Reed

Results 29 comments of Josh Reed

I’ll take a look. Do you have a benchmark or stress test I could run it against? I haven’t yet dived too deep on the code On Sat, Nov 4,...

I wonder if something like this would fit better _outside_ DNF. One of challenges I've face with DNF is its memory usage, as it will attempt to solve package needs...

Well for now, there is no notion of caching the results of factory functions in Incant at all. So there's no notion of scope anad no obvious place to put...

I'm sorry that I'm not defining my use cases, well. I guess I'm more just thinking through these problems as I type them. I think doing this kinda work may...

> One place in which we could cheaply start to do more garbage collection would be to convert the interning `Key`s that the engine currently uses to a WeakRef map...

> * Add a collection of roots with the time when they were requested to [InnerGraph](https://github.com/pantsbuild/pants/blob/f95ed94d13a8531a7fdab8318d9f597b08d04371/src/rust/engine/graph/src/lib.rs#L67-L71): > ```rust > roots_by_age: HashMap, > ``` > * (confirm that your changes compile...

> declare -r VAR=$(command that always returns 0 - or not) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. That's a different case than this, and...

I second this. Honestly, sphinx-based automated documentation of the docstrings you guys already put in the code would make developing plugins _much_ easier. Right now I read the code to...

Yes and if I remember correctly this generation is more opt-in than opt-out, so it's pretty easy to tailor this. I can perhaps help with this later this week or...