Josh Rickmar

Results 198 comments of Josh Rickmar

This pull request doesn't pass the build tests, has committed merge conflicts in a file only you have touched, commits a 4M executable, and you want me to review this?

@githubsands will take this (but i can't assign him the issue through github because he's not part of the decred org)

Sure. For this you will want to create a new function in the txauthor package that performs this behavior, since it would be impossible to add it to the existing...

Increasing the tx fee by leaving off the change output entirely would be the simplest correct way, and it is a rare edge case so I don't see any issues...

Hmm, so this isn't quite what I had in mind when I was talking about changing fetchAccountInfo to not return a type specific to BIP0044 accounts. I was instead thinking...

A separate file seems reasonable, but it makes more sense to indicate when a new random wallet was created instead of an imported seed. In this case, the initial sync...

Copying some of my thoughts from 1105: * This should be tracked by the DB. * It should track the wallet's birthday for newly created wallets. This has the additional...

I'm generally leaning towards some solution with a new purpose key (requires reseed, but only if you require these keys). > From perspective of the user that doesn't mind reseeding,...