Missing Defaults Values $settings for \linfo\linfo

Open KTP95 opened this issue 9 years ago • 2 comments

$linfo = new \Linfo\Linfo; --> create problem without $setting vars,

Maybe possible do a defaults values and hard-include it in the class...

Dec 12 '16 20:12 KTP95

That would be a good idea. Feel free to make a PR.

Apr 23 '17 19:04 jrgp

I'm not 100% sure about it - what would be enabled/disabled by default? I think that this package handles sensitive data and cause of this the user should be 100% aware of what this package does on his machine. So yes: it will help the lazy dev to use it - but it has also the risk that this package does things that the dev doesn't want it to do.

So just want to open a critical discussion, about pro-con, before doing this PR.

Apr 23 '17 20:04 Gummibeer