Dwarfstack

[oltolm]

I made the code in mgwhelp.cpp use the dwarfstack library. I had to fork it and change its API. All tests are green.

Dwarfstack fixes this problem #97 and also some other small problems. The code has good quality and I fixed a performance problem that I found.

[codecov[bot]]

Codecov Report

:x: Patch coverage is 85.00000% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 50.93%. Comparing base (5dc71ed) to head (987aa04).

Files with missing lines	Patch %	Lines
src/mgwhelp/dwarf_find.cpp	79.31%	4 Missing and 2 partials :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   51.11%   50.93%   -0.18%     
==========================================
  Files          15       15              
  Lines        2160     1820     -340     
  Branches      824      671     -153     
==========================================
- Hits         1104      927     -177     
+ Misses        809      691     -118     
+ Partials      247      202      -45     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jrfonseca]

Sorry for the silence. I haven't had much time to sit down at my computer these past weekends.

Thanks. I think this is a good direction.

Ideally we'd use a git submodule for dwarfstack. If we need modifications, then use our own fork, though ideally we'd upstream those. If we really need a fork long term, then I might need to promote drmingw to a GitHub organization to better organize those forks. In the meanwhile, you can just point to your own dwarfstack fork.

Could you please provide the diff of your dwarfstack changes? I'd like to understand what are these changes.

[oltolm]

I have forked dwarfstack and added it as a submodule. You can see my changes in the fork. It is mostly splitting a large function into multiple functions. There are almost no functional changes.