Juliette

Review the `WordPressVIPMinimum.Performance.RemoteRequestTimeout` sniff for the following in as far as relevant to that sniff: - [ ] Code style independent sniffing / Correct handling of quirky code Typical things...

Review the `WordPressVIPMinimum.Performance.RegexpCompare` sniff for the following in as far as relevant to that sniff: - [ ] Code style independent sniffing / Correct handling of quirky code Typical things...

## What problem would the enhancement address for VIP? Prevent potential fatal `ArgumentCount` errors. ## Describe the solution you'd like Inspired by the `AlwaysReturnInFilter` sniff, I was thinking that once...

Review use of external sniffs

1

Both VIPCS rulesets currently use the following external sniffs: ``` Generic (5 sniffs) ------------------ Generic.NamingConventions.ConstructorName Generic.PHP.DisallowShortOpenTag Generic.PHP.NoSilencedErrors Generic.PHP.Syntax Generic.VersionControl.GitMergeConflict PSR2 (1 sniff) --------------- PSR2.Files.ClosingTag Squiz (3 sniffs) ---------------- Squiz.PHP.CommentedOutCode Squiz.PHP.Eval...

Improve handling of initial values in initializers

1

I noticed when fixing up the CS, that the `VariableAnalysisSniff::processVariableAsStaticDeclaration()` uses outdated assumptions on what can be part of an initial value: ```php // Are we a static declaration? //...

Unused parameters in methods in abstract classes

3

Abstract classes can contain abstract methods which are _required_ to be overloaded, but they can also contain empty methods which are _optional_ to overload. ```php abstract class Foo { //...

Allow for functions which set variables in the current scope

3

In PHP there are a number of functions which can set variables in the current scope. Sometimes by reference to a passed parameter (first examples), sometimes just plainly in the...

Use `File::getMethodParameters()`

5

https://github.com/sirbrillig/phpcs-variable-analysis/blob/2976bca165ff20efa391028bb1a779c403bbbab8/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php#L464-L467 I have no clue how old that comment is, but it definitely isn't valid anymore and hasn't been valid for a long time. The `File::getMethodParameters()` utility method can retrieve...

The array in `Constants::getPassByReferenceFunctions()` includes a number of methods, but no indication that: 1. These are methods and should only be recognized as the function when called as a method....

`static` variables can contain constant scalar expressions on declaration since PHP 5.6. While the `VariableAnalysisSniff::checkForStaticDeclaration()` takes some of that into account, it's incomplete and doesn't account for all possible syntaxes...