Juliette
Juliette
@rebeccahum I wouldn't be surprised if there is an issue open for it already, but yeah, go ahead, though search in the repo first for existing issues.
Hmm... while I understand where you are coming from, I don't think this is a good idea. The `constant()` function should _only_ be used when the name of the constant...
> But in instances like our vip-go-mu-plugins, sometimes we have to call constant( 'FOO_BAR' ) in our code to make our unit tests happy: https://github.com/Automattic/vip-go-mu-plugins/blob/fdd99cf535e55eeda46d7a11a4cbb1603d8bc666/tests/mock-constants.php. So, doing that can result...
I've prepared the branch with the necessary changes for this, but am a little hesitant to pull it as of yet. PHPCSUtils is at this moment at `1.0.0-alpha3`. This means...
> That said, what would be the impact on using 1.0.0-alpha3? Could it be added, and you only improve sniffs with the Utils bits you think are most stable? At...
Ok, so there are technical reasons why this is not allowed and should not be changed until the WP minimum PHP requirement _has_ changed to 5.4 or higher. Like @KestutisIT...
> Once WP switches bumps to 5.6+, I don't see any reason for WPCS to continue to actively disallow short echo tags. @GaryJones It's a handbook rule/`Core` ruleset , so...
@sergeymitr Thanks for the reminder. As this is forbidden in the handbook, we cannot blindly change this. I have put the topic on the shortlist for a next post on...
@rebeccahum Instead of roasting (and sorry, yes it would be a painful roasting), let's try something different. Let's start with a little exercise: * Can you try to write out...
As per the remark in the ruleset: > This is still safe, just sub-optimal If you look at the code for the functions involved in WP Core, the only real...