Juliette

Results 2034 comments of Juliette

As of today, the wiki is publicly editable via PRs to the https://github.com/PHPCSStandards/PHP_CodeSniffer-documentation repository. The intention is for that repository to eventually also host the website and for the information...

@gmazzap FYI: I've been looking into this and have prepared a branch, but saw all sorts of other potential improvements to be made while working on this. Hence the open...

@amenk Thank you for your PR and your willingness to contribute to PHPCS. Currently CI does not pass on this PR, this needs to be fixed before someone will look...

@amenk Thanks for the PR. I've been trying to reproduce the issue, but am failing. I've also tried to see if this fixes #787, which I can reproduce, but no...

> Is the file maybe only cleaned after fully written? [It is indeed](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/726bbc13849a80b0c3b4cfa43c7b5287c0b864e9/src/Reporter.php#L238-L240), though it depends on the report type used and such, but if there are colours to content...

@rikvdh :point_up: Might also be something to suggest to PER ? Don't think this is covered in the PER standard yet.

> This library should include sniffs that developers can run locally as part of composer run-tests and which run on GitHub Actions which detect any coding standards violations for test...

I generally still use `esc_js()` within `wp_localize_script()` when setting up the variables. Is that not correct ?