Juliette

Results 2034 comments of Juliette

While working on this and on an additional method `AttributeBlock::appliesTo()`, I discovered a bug in the PHPCS tokenizer, which ends up **_removing_** tokens from the token stream if they are...

A [PR to fix the upstream issue has been pulled](https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/1280) and should be included in PHPCS 3.13.5.

Thanks for opening this issue @rodrigoprimo. As you may have guessed, I'm in favour of the proposed change. Having said that, I don't think the sniff should blindly ignore trailing...

P.S.: by the looks of it, there is a work-around which could be applied at this time already and that is to use a trailing comment starting with `#`. Not...

> > Maybe the sniff shouldn't look for specific annotations, but for any trailing comment which starts with an @ sign + tag, i.e. '^// @[a-z0-9-]+'i ? > > I...

Oh and for the record: There _may_ or _may not_ be a space between the comment marker and the `@` (confirmed via a code search of a larger set of...

Just thinking out loud: is a property the way to go here or should this be solved via error codes, i.e. having a different error code for a completely empty...

Error codes are not supposed to contain `.`s, which is why I suggested `DetectedCatchComment`. Adding additional error codes will be BC-break, but only a quite minor one in this case,...

> I wonder if single-line trailing comments using `/* ... */` should be flagged as well or not. I think they should, as this is yet another valid type of...