Juliette

Hi Samuel, This is **not** a false positive. The regex in the `preg_replace()` is: `'!s:(\d+):"(.*?)";!es',`. The `!` is used as the regex delimiter, which means that `s:(\d+):"(.*?)";` is the effective...

The `preg_replace_callback()` function has existed since PHP 4, so why not use it unconditionally and remove the `else` part altogether ? If you still want to be compatible with PHP...

The `foreach` is missing curly braces, which is the cause for the false positive.

> @jrfnl can you please try to directly communicate with Matomo Development Team (here is the link to the ticket on their platform) https://forum.matomo.org/t/php-compatibility-checker-shows-critical-errors-for-wp-matomo-integration/43318/2 I'll forward your reply to them,...

@hheckner Do I really have to explain the basic principles of open source to you ? * Nobody in open source owes you anything. * If anyone responds to whatever...

> I don't want to sound impolite. It was just the fact that I was forwarding the answers from both sides. You did and that's not my problem. You asked...

@TimSmith It should not be fixed like that. This should be fixed by making sure all relevant `vendor` files are included with the plugin.

@TimSmith That's what I mean, the `vendor` directory in the plugin wasn't updated correctly for the `1.5.0` release and this needs to be fixed. An update to `PHPCompatibilityWP` `2.1.0` in...

> Sorry about my ignorance, but how would you do that? @tatuiot Are you asking cause you want to create a fix ? or because you want to "fix" this...

@ehausen Rolling back will mean the scans being run will be not be up to date, i.e. a lot of issues won't be caught and reported.