vimagit icon indicating copy to clipboard operation
vimagit copied to clipboard

Any plans to add blame command?

Open dkns opened this issue 9 years ago • 8 comments

Hi, awesome plugin! Thanks a lot for creating it. One thing I would love to see is blame command implemented. Any plans to add it in the future?

dkns avatar Jan 09 '16 12:01 dkns

+1

fpnick avatar Jan 09 '16 12:01 fpnick

Hi

fugitive and vim-gita already implement nice git blame feature (gita's one is really nice, have a look).

Actually, both existing solutions seems OK to me. I don't intend to copy something working well. But if you have any idea of a git blame integrating well in the magit workflow, let me know!

I'll check how emacs magit handles got blame, to see if it is inspiring.

jreybert avatar Jan 10 '16 09:01 jreybert

Yeah, vim-gita is awesome but I'd rather not load separate vim plugin just to have nice looking blame interface. Let me know if you need any help with developing this one.

dkns avatar Jan 13 '16 12:01 dkns

As I don't see what vimagit could bring more for git blame vim integration, I don't plan to implement it.

This is the Unix philosophy: Write programs that do one thing and do it well.

If you can see a way where the vimagit workflow could integrate a git blame output in an interesting manner, I would be happy to see it! Feel free to reopen this ticket in this case.

jreybert avatar Apr 15 '16 11:04 jreybert

@jreybert why vimagit has to bring more to git blame then fugitive or gita? Most of people want to use only one git plugin, and as @dkns noted, pulling in another plugin just to use single feature is redundant. It's same for me, only thing i use from fugitive is blame, since i don't like the other parts, but here i like everything, but only missing this blame feature. I agree with Unix philosophy, but i don't think it applies here. It would apply if we would have a plugin that is used only for blame, like a vim-fugitive-blame, but that's not the case, fugitive has a lot of it's own features.

kristijanhusak avatar Apr 05 '18 10:04 kristijanhusak

Hi @kristijanhusak .

You are quite right, use only one plugin would be better. But:

  • I don't have the time to add features which do not exist in other plugins (#23, #142, #83, one day handle rebase like magit), mimic existing behavior is a very low priority
  • fugitive is not that huge, loading it at vim startup is not noticeable. Unify fugitive blame mapping with vimagit should be easy.

So, I am sorry, but integrate a blame feature in vimagit is very low priority...

jreybert avatar Apr 05 '18 11:04 jreybert

@jreybert I understand that it's low priority, and that's completely fine, but rejecting it should not be a case. @dkns offered to contribute, so if someone else can do it, why not.

kristijanhusak avatar Apr 05 '18 12:04 kristijanhusak

You make a point. I remove the rejected flag and reopen the issue.

@dkns, if you are still interested to develop this new feature, feel free!

jreybert avatar Apr 05 '18 12:04 jreybert