modgit icon indicating copy to clipboard operation
modgit copied to clipboard

modman filters with chars following a '*' aren't parsed properly in move_files()

Open jeffreyodum opened this issue 11 years ago • 0 comments

If a module contains a modman file containing filters like "*{something}", files that match that filter are not deployed in move_files().

The problem happens when the modman file’s filter expression ends with “{something}”, like “app/etc/modules/.xml”.

Line 337 of modgit is:

line=”${line/*/}” # remove * char

Which means the comparison on line 339 of:

if [[ "$file" =~ ^$1 ]]

will fail in these cases as it will evaluate to something like:

if [[ "app/etc/local.xml.phpunit" =~ "app/etc/modules/.xml" ]]

jeffreyodum avatar Jan 27 '14 19:01 jeffreyodum