pngme_book

pngme_book copied to clipboard

Fix PNG header in test_invalid_chunk

2

This is to fix issue #14. AND it also includes a utility to sync the `src/tests/*_tests.rs` test code to the bottom of the `code/src/*.rs` skeleton code. This will make it...

softmoth

chunk_type: safe-to-copy bit is 0 for critical chunks

1

The PNG spec states "the safe-to-copy bit will always be 0 for critical chunks". All of the tests should respect this. One test has been added to ensure this (`chunk_type::test_invalid_safetocopy`)....

softmoth

Unit test test_invalid_chunk in Chapter 3 should add a standard header

1

```rust #[test] fn test_invalid_chunk() { let mut chunk_bytes: Vec = testing_chunks() .into_iter() .flat_map(|chunk| chunk.as_bytes()) .collect(); #[rustfmt::skip] let mut bad_chunk = vec![ 0, 0, 0, 5, // length 32, 117, 83,...

huyufeifei

The PNG spec mentions a few things that should always be true for valid chunk types. It looks like tests do check for these, but the spec also says that:...

jgao222