amdefine

amdefine copied to clipboard

This might be difficult to fix and rarely an issue, but if a non-AMD defines a constant called "define" in its outer scope, amdefine/intercept will cause a syntax error (redefinition).

ddurschlag

If a .js file begins with a #!/ line, the require is placed above it, making the shebang line a syntax error.

ddurschlag

https://docs.npmjs.com/files/package.json suggests multiple licenses require wrapping parens https://github.com/pivotal-legacy/LicenseFinder/issues doesn't parse this license correctly thank you!

michaelglass

`intercept` does not work with `babel-register`

1

When using with babel-register the `intercept` hook kills the registration for babel, so no babel compilation happens, resulting in error ``` of define !== 'function') {var define = require('amdefine')(module)}import ok...

Poetro

compatible some interpreter files with herder: ``` bash #!/usr/bin/env node ```

allex

Title says it all. Quick fix is to change line 131 in amdefine.js from ``` return normalize(filePath, path.dirname(module.filename)); ``` to return normalize(filePath, module.filename);

geloescht

Option to use requirejs path resolution logic

19

This came up from a use case from @chrispitzer: If you have modules coded to use amdefine and they work in reqiurejs, if they need to run in something like...

jrburke