[Mod incompatibility] Hardcore Revival

[psymin]

There are a couple of issues with this mod.

Dead players can teleport around using the teleportation locomotion.

They cannot click "accept fate" when they die.

https://minecraft.curseforge.com/projects/hardcore-revival

[BlayTheNinth]

Knocked out players can still teleport around

Vivecraft only checks for isDead, which only happens a second after the player has died due to EntityLivingBase.deathTime delaying it. This means, technically, a dead player can still move around for a second after death (assuming they weren't locked in a death screen GUI).

https://github.com/jrbudda/Vivecraft_112/blob/599fb6bb4c1bbf8df4963d25aedbfd3cb0b34d77/src/com/mtbs3d/minecrift/gameplay/trackers/TeleportTracker.java#L72-L78

In Hardcore Revival, isDead is only set to true once the player fully died, since otherwise the entity would get removed. deathTime is correctly set though, so a simple solution would be for Vivecraft to check for deathTime > 0 as well.

Clicking "Accept your Fate" button just closes the screen

The button appears clickable and has a hover effect, but trying to click it just closes the screen. Most likely related to the keyboard which just closes the screen if clicked outside of it? Couldn't find the relevant code in Vivecraft though.

Lava Death causes continuous controller vibration

Probably caused by this, I assume the player is still taking damage even when out of health: https://github.com/jrbudda/Vivecraft_112/blob/599fb6bb4c1bbf8df4963d25aedbfd3cb0b34d77/patches/net/minecraft/client/entity/EntityPlayerSP.java.patch#L120-L131

This could be fixed on Hardcore Revival's side by making knocked out players immune to fire.