KerbalEngineer icon indicating copy to clipboard operation
KerbalEngineer copied to clipboard

Delta V readouts not displaying / updating within the VAB after update 1.11

Open TupperWareContainer opened this issue 4 years ago • 10 comments

See title; update 1.11 broke the delta V readouts to where they only update once you re-open the craft by exiting the VAB and re-entering, could be a problem with initializing the variables

Readouts when entering the VAB: 20201218140934_1

Readouts after adding an extra fuel tank to the craft: 20201218141020_1

I have tried re-installing Kerbal Engineer Redux but it did not fix the problem

The delta V readouts only update when launching the craft or exiting and re-entering the VAB, otherwise it works fine when you actually launch the craft

TupperWareContainer avatar Dec 18 '20 14:12 TupperWareContainer

I've observed this too. It seems related to crewed parts. Building a craft without a crewed part causes the dV calculation to work fine. Sometimes this can be worked around by re-rooting the craft to a non-crewed part.

I also observe a (probably related) issue where the vessel tab in engineer in flight does not render and when enabled seems to have a severe memory leak.

Here is an excerpt from the debug log after a minimal repro (command pod as root part with SRB under it):

[LOG 13:06:13.476] KerbalEngineer -> Exception SimManager.StartSimulation() // System.NullReferenceException: Object reference not set to an instance of an object
  at KerbalEngineer.Extensions.PartExtensions.getCrewAdjustment (Part part) [0x00072] in <df610534f02e44eabb2fe7c95c06a0aa>:0 
  at KerbalEngineer.VesselSimulator.PartSim.New (Part p, System.Int32 id, System.Double atmosphere, KerbalEngineer.LogMsg log) [0x001c9] in <df610534f02e44eabb2fe7c95c06a0aa>:0 
  at KerbalEngineer.VesselSimulator.Simulation.PrepareSimulation (KerbalEngineer.LogMsg _log, System.Collections.Generic.List`1[T] parts, System.Double theGravity, System.Double theAtmosphere, System.Double theMach, System.Boolean dumpTree, System.Boolean vectoredThrust, System.Boolean fullThrust) [0x00185] in <df610534f02e44eabb2fe7c95c06a0aa>:0 
  at KerbalEngineer.VesselSimulator.SimManager.StartSimulation () [0x000ba] in <df610534f02e44eabb2fe7c95c06a0aa>:0 

(this repeats many times.)

602p avatar Dec 18 '20 19:12 602p

Thanks I've got 2 weeks vacation til new years and will take care of it.

On Fri, Dec 18, 2020 at 2:07 PM Louis Goessling [email protected] wrote:

I've observed this too. It seems related to crewed parts. Building a craft without a crewed part causes the dV calculation to work fine. Sometimes this can be worked around by re-rooting the craft to a non-crewed part.

I also observe a (probably related) issue where the vessel tab in engineer in flight does not render and when enabled seems to have a severe memory leak.

Here is an excerpt from the debug log after a minimal repro (command pod as root part with SRB under it):

[LOG 13:06:13.476] KerbalEngineer -> Exception SimManager.StartSimulation() // System.NullReferenceException: Object reference not set to an instance of an object at KerbalEngineer.Extensions.PartExtensions.getCrewAdjustment (Part part) [0x00072] in :0 at KerbalEngineer.VesselSimulator.PartSim.New (Part p, System.Int32 id, System.Double atmosphere, KerbalEngineer.LogMsg log) [0x001c9] in :0 at KerbalEngineer.VesselSimulator.Simulation.PrepareSimulation (KerbalEngineer.LogMsg _log, System.Collections.Generic.List`1[T] parts, System.Double theGravity, System.Double theAtmosphere, System.Double theMach, System.Boolean dumpTree, System.Boolean vectoredThrust, System.Boolean fullThrust) [0x00185] in :0 at KerbalEngineer.VesselSimulator.SimManager.StartSimulation () [0x000ba] in :0

(this repeats many times.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jrbudda/KerbalEngineer/issues/66#issuecomment-748266866, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOWQQ7DRMFJTBG5NSEO4TTSVOR73ANCNFSM4VBHBFHA .

jrbudda avatar Dec 19 '20 03:12 jrbudda

To anyone else finding this thread, a temporary workaround I have been using: in Physics.cfg change kerbalCrewMass to 0.0, perSeatReduction to 0.0 and perCommandSeatReduction to 0.049. Then if using ModuleManager delete the MM cache files. If I understand the comments right this will mean all parts act as if they were fully occupied. It also causes KER to skip the code path that is erroring out for me, and it seems to work fine after this patch.

602p avatar Dec 19 '20 04:12 602p

Related: Adding a Kerbal to a pod actually reduces the rocket's mass displayed in KER, removing a Kerbal increases the mass. Unrealistic mass of -2177kg per Kerbal (incl. jetpack and EVA chute). Only seems to happen loading pre-existing rockets, not with new builds. 602p's workaround fixes this issue.

Sinomen avatar Dec 19 '20 10:12 Sinomen

Hi everyone! I'm new to this. Where do I find this "Physics.cfg" ? I didn't see a file named like this in any of the folders in the zip file. I didn't download the separate Source Code since in the "ReadMe" it only says to download this zip file, uncompress it, and put it in the GameData folder inside the game's folder. Help?

KerbonautRecruit avatar Dec 22 '20 02:12 KerbonautRecruit

@KerbonautRecruit it's not a file from the mod. It's a file from the base game. It is next to KSP_x64.exe (in the folder containing GameData -if you installed it via steam it should be named Kerbal Space Program.)

602p avatar Dec 22 '20 03:12 602p

Just for situational awareness, MJ is doing real-time dv updates in the VAB, but is having an issue where it's not counting current crew mass in calculations. Sort of the opposite problem of 602p's solution - it thinks every crewed part is empty. It's possible there may be a common data-polling solution for both mods.

GHrynk avatar Dec 22 '20 14:12 GHrynk

Can confirm. KER on KSP 1.11 doesn't calculate delta v properly sometimes. I cannot tell what causes it to stop working, or to resume working.

Screenshot: screenshot21

Current Mods: A bunch of Near Future tech KER Kerbal Alarm Clock EVE, Scatterer

whiterook6 avatar Dec 22 '20 19:12 whiterook6

Additional screenshots, in case they help: KER appears to crash when the Vessel view is open.

screenshot22 screenshot25

whiterook6 avatar Dec 22 '20 20:12 whiterook6

Dunno if it's any help, but when it computes TWR, there is a difference between information given in staging section and vessel card. Judging by my rocket performance, vessel card information was correct

kerdiff

qfilip avatar Dec 23 '20 23:12 qfilip