littlefs-python icon indicating copy to clipboard operation
littlefs-python copied to clipboard

Rework of the Github Actions

Open jrast opened this issue 2 years ago • 5 comments

jrast avatar Aug 07 '23 14:08 jrast

I know you're reworking, but just commenting that I was able to install the prebuilt macos binary for arm:

Downloading littlefs_python-0.6.2-cp311-cp311-macosx_11_0_arm64.whl (150 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 150.4/150.4 kB 3.5 MB/s eta 0:00:00
Installing collected packages: littlefs-python

BrianPugh avatar Aug 07 '23 18:08 BrianPugh

Yeah, currently the Apple Silicon wheels are built, but it seems like overly complicated... I want to simplify and streamline the build process.

jrast avatar Aug 07 '23 19:08 jrast

in my python template, I have a long, but not-too-complicated pipeline. It particularly long so that:

  1. Everything can run in parallel.
  2. Each OS has it's own job. Other workflows like to have a bunch of steps that run if: matrix.os == 'ubuntu-latest' and such, but I think it actually ends up making the workflow harder to read and more error-prone. Many platforms have their own quirks and require their own step tweaks.

If you are interested in using Poetry for this project, I can help set that up.

BrianPugh avatar Aug 07 '23 20:08 BrianPugh

@BrianPugh thanks for the inputs. Can you confirm if the wheels created by the new pipeline (contained in the following artifacts: https://github.com/jrast/littlefs-python/actions/runs/5786354962?pr=46#artifacts) also work? With the new pipeline the builds are run in parallel for the different python versions which leads to a runtime of about 15 minuts which is acceptable.

I use poetry in other (private) projects but as of now I prefere the current setup for this project.

jrast avatar Aug 08 '23 08:08 jrast

just tested littlefs_python-0.6.2.dev10+gf95a12b-cp311-cp311-macosx_11_0_arm64.whl and it installed fine!

BrianPugh avatar Aug 08 '23 17:08 BrianPugh