Joe Ranalli
Joe Ranalli
I guess I rambled, but it's kind of a two-part idea. I think ```substance.phase()``` that returns a string or ENUM value of the phase would be useful for a variety...
So I was thinking of liquid, vapor, mixture, supercritical categories. Textbooks and articles seem to define supercritical as both pressure and temperature exceeding the critical values, so there is a...
I don't think it would be possible to get the error messages to do all the lifting on this, because the users have different goals in mind. As an example,...
When this is touched, bear in mind that this is different for input & output properties. That is, you can't set a state from the ratio of specific heats.
>(2) It bothers me deeply that it is possible to specify temperature and pressure using multiple unit systems simultaneously. The one reason I felt this case justified the conflicting units...
Possible point for future conversation, this may couple with improving the efficiency of the published docs process. I recently used sphinx for the first time for one of my other...
This one has led to failures in our test suite for air entropy. Those tests were all based on PM-generated reference states just to monitor changes to code. I will...
Alright, there are two separate branches I added from the `igtools` branch. `igtools-testsfix` updates nothing but the test suite to accommodate expected behavior with changes introduced by igtools: - allow...
Two of the TODO's are sorted out. There are definitely some failed tests in here that indicate bugs. I do have code to address some of them.
Ok I have a draft of the entire test suite based on your changes completed. Of 12,541 tests, 2,350 currently fail. The majority are easy fixes, like a changed variable...