learn.jquery.com icon indicating copy to clipboard operation
learn.jquery.com copied to clipboard

Merging attributes page into Manipulating Elements

Open connorcartwright opened this issue 8 years ago • 5 comments

Hey guys @AurelioDeRosa @agcolom

Following the comments made in issue #642 by devs4u I’ve merged the attributes page into the manipulating elements page.

I've added some line spacing and moved around the text a bit in the Manipulating Attributes section. I also added in a sentence from the old attributes page and a getter code example.

Let me know if you have an feedback or if there are any problems and I'll get on it asap :bowtie:

connorcartwright avatar May 04 '16 22:05 connorcartwright

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

jquerybot avatar May 04 '16 22:05 jquerybot

@ConnorCartwright Thank for the PR :-) Looks good to me. @AurelioDeRosa Does this look good to you?

agcolom avatar May 05 '16 21:05 agcolom

I've added a few comments to improve the PR. Overall I'm excited to see that we have a new contributor. Thank you @ConnorCartwright!

AurelioDeRosa avatar May 05 '16 21:05 AurelioDeRosa

Hey @AurelioDeRosa

No problem, thank you for the feedback!

I've removed the line spacing between those two sentences and added a link to the .attr() api page on its first mention.

Would it be best to add the attributes.md file back in and give it a meta tag to redirect, something like:

<meta http-equiv="refresh" content="0; url=http://learn.jquery.com/using-jquery-core/manipulating-elements/" />

Or is there a simpler way I'm missing?

connorcartwright avatar May 05 '16 22:05 connorcartwright

I think we might have a process in place for these situations but I'd like to have our expert opinion @gnarf

AurelioDeRosa avatar May 05 '16 22:05 AurelioDeRosa