learn.jquery.com icon indicating copy to clipboard operation
learn.jquery.com copied to clipboard

contribution guidelines not in sync with the rest of jquery

Open toejough opened this issue 11 years ago • 3 comments

The contribution guidelines (https://github.com/jquery/learn.jquery.com/blob/master/CONTRIBUTING.md) are not in sync with other jquery projects (such as https://github.com/jquery/jquery.com/blob/master/CONTRIBUTING.md) and don't point you towards the overall guidelines (here: http://contribute.jquery.org/).

This means that first-time contributors have no idea how to do things correctly... :-/

toejough avatar Sep 20 '14 01:09 toejough

I'd like to propose that we rename contributing.md to contribute.md

and then create a CONTRIBUTING.md with the proper guidelines for the repo.

The confusion is that contributing.md is an actual top level page on the learn site https://learn.jquery.com/contributing/

cc. @scottgonzalez

RedWolves avatar Jan 08 '15 05:01 RedWolves

I'd like to propose that we rename contributing.md to contribute.md

If you want to do that, you can, it's not really related to this issue.

and then create a CONTRIBUTING.md with the proper guidelines for the repo.

This file already exists, but has bad content, which is what this issue is about.

The confusion is that contributing.md is an actual top level page on the learn site https://learn.jquery.com/contributing/

If you're referring to this issue and the preceding confusion and problems, this is completely unrelated. The problem is that the content is bad and out of sync with the standard contribution process.

If you're referring to some separate confusion about the relationship between the two, the two page are technically separate, they're only linked because @ajpiano decided to do so.

scottgonzalez avatar Jan 08 '15 12:01 scottgonzalez

@scottgonzalez @RedWolves I opened two PRs to fix this: #634 and jquery/jquery-wp-content#343. Mind giving those a review?

arthurvr avatar Mar 01 '15 14:03 arthurvr