jquery-ui icon indicating copy to clipboard operation
jquery-ui copied to clipboard

jQuery UI v1.13 getNumber RegExp not working for dateRange

Open glanujnehra opened this issue 8 months ago • 1 comments

Description

Due to the changes introduced in jQuery UI v1.13 for function getNumber selecting dateRange from date clear out to date

getNumber = function( match ) {
      var isDoubled = lookAhead( match ),
      size = ( match === "@" ? 14 : ( match === "!" ? 20 :
      ( match === "y" && isDoubled ? 4 : ( match === "o" ? 3 : 2 ) ) ) ),
      minSize = ( match === "y" ? size : 1 ),
      digits = new RegExp( "^\\d{" + minSize + "," + size + "}" ),
      num = value.substring( iValue ).match( digits );
      if ( !num ) {
      throw "Missing number at position " + iValue;
      }
      iValue += num[ 0 ].length;
      return parseInt( num[ 0 ], 10 );
},

RCA

Updating jQuery UI from v1.9.2 to v1.13.2 changes the behaviour of getNumber function which extract a number from the string value. The issue was also observed when switching to version 1.12.1

Solution

changing v1.13.2 digits = new RegExp( "^\\d{" + minSize + "," + size + "}" ), to v1.9.2 digits = new RegExp('^\\d{1,' + size + '}'),

will fix the issue.

Screenshot

wwwwww Screenshot 2024-06-18 at 1 37 05 AM

Affected Product

Magento -> Admin -> Reports -> Products -> Ordered

Error

Missing number at position 5

Link to test case

glanujnehra avatar Jun 17 '24 20:06 glanujnehra