jquery-ui icon indicating copy to clipboard operation
jquery-ui copied to clipboard

Remove IE8 support that crashes in some cases (in my case using Drupa…

Open joejoseph00 opened this issue 6 years ago • 6 comments
trafficstars

Remove useless IE8 support (causes problems in some use cases, particularly when using jQuery ui with the Drupal contrib module named "views_load_more" module. History is here: https://github.com/jquery/jquery-ui/pull/1893 …l and the views_load_more module in combination with jQuery UI 12.1

joejoseph00 avatar Aug 20 '19 00:08 joejoseph00

Yay, passing!

joejoseph00 avatar Aug 20 '19 01:08 joejoseph00

I set the milestone to 1.14.0 it as we agreed not to remove IE 8 workarounds from 1.13 yet. If you'd like to land it sooner, we'd need a way to have the patch apply only when needed. However, the existing check already tries to achieve exactly that... So it'd be good to get more details about the crash: what exactly causes the crash, in which browsers, etc.

mgol avatar Jan 03 '22 15:01 mgol

@mgol might as well wait for 1.14.0 .

with that said, IE8 is basically kaput for all intents and purposes. The only people running it would be those not connected to the internet and they'd probably not be changing versions of jQuery.

joejoseph00 avatar Jan 03 '22 15:01 joejoseph00

CLA Signed

The committers are authorized under a signed CLA.

  • :white_check_mark: Joseph Olstad (3fbbfaf126408574ec53983abccb8985c4a7f34b)

I signed all the approvals now

joejoseph00 avatar Jan 03 '22 18:01 joejoseph00

Sure, no problem. Take note, though, that we've released 1.13.0 not so long ago so I wouldn't expect 1.14.0 to arrive any time soon. We want to let it stay on 1.13.0 for a while, let folks update, discover & fix regressions from 1.12.1, etc.

mgol avatar Jan 03 '22 21:01 mgol