jquery-ui
jquery-ui copied to clipboard
[1.13] Dialog: Add `icons` option to support titlebar icons
Still needs tests, but I wanted to make sure the team is good with adding this option.
See ticket 15121.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Seems good!
Added tests.
Note that I also changed the implementation because the original implementation didn't handle updating the icon after init.
This PR now also removes the back compat for dialogClass
. The deprecated tests were failing because I hadn't updated the options in common-deprecated.js
. Since this can't land in 1.12 anyway, I figured I might as well just remove the back compat now.
Yeah, this can't be released until 1.13.
For me this would be an important function. Could 1.13.3 be released? Thanks