jquery-ui icon indicating copy to clipboard operation
jquery-ui copied to clipboard

Published 20 hours ago • verified publisher icon jquery

[1.13] Dialog: Add `icons` option to support titlebar icons

Open scottgonzalez opened this issue 7 years ago • 7 comments

Still needs tests, but I wanted to make sure the team is good with adding this option.

See ticket 15121.

scottgonzalez avatar Jan 25 '17 20:01 scottgonzalez

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

jsf-clabot avatar Jan 25 '17 20:01 jsf-clabot

Seems good!

jzaefferer avatar Jan 25 '17 21:01 jzaefferer

Added tests.

scottgonzalez avatar Jan 29 '17 20:01 scottgonzalez

Note that I also changed the implementation because the original implementation didn't handle updating the icon after init.

scottgonzalez avatar Jan 29 '17 20:01 scottgonzalez

This PR now also removes the back compat for dialogClass. The deprecated tests were failing because I hadn't updated the options in common-deprecated.js. Since this can't land in 1.12 anyway, I figured I might as well just remove the back compat now.

scottgonzalez avatar Feb 01 '17 18:02 scottgonzalez

Yeah, this can't be released until 1.13.

scottgonzalez avatar Feb 06 '17 15:02 scottgonzalez

For me this would be an important function. Could 1.13.3 be released? Thanks

nagyimre1980 avatar Oct 10 '22 17:10 nagyimre1980