jquery-mousewheel icon indicating copy to clipboard operation
jquery-mousewheel copied to clipboard

Event alias

Open arschmitz opened this issue 9 years ago • 7 comments

This PR removes all dependency on the jQuery Core event/alias module and deprecated module

It also updates the jQuery core dependency to be >= 1.7.0 to allow this removal.

Browserify build was not working when tested with current browserify updated example to work again and update to use jQuery proper jquery-browserify has not been updated in 3 years.

arschmitz avatar May 22 '15 15:05 arschmitz

Looks good to me

jzaefferer avatar Jul 01 '15 12:07 jzaefferer

@jzaefferer added removal of that property

arschmitz avatar Jul 01 '15 14:07 arschmitz

:+1:

jzaefferer avatar Jul 01 '15 15:07 jzaefferer

I'm okay with this change but should we consider it a major break? Bower and npm users should be protected by the dependencies declared in their files but the majority of users are probably just including the file and putting this out as e.g. 3.1.14 may not make things clear.

dmethvin avatar Jul 15 '15 18:07 dmethvin

@dmethvin thats probably a good point we should probably do a full version bump

arschmitz avatar Aug 05 '15 15:08 arschmitz

The readme in test/browserify still says "npm install jquery-browserify", the rest looks wrong, too. Shouldn't it describe how to install browserify?

jzaefferer avatar Aug 05 '15 16:08 jzaefferer

@jzaefferer I opened #150 for that.

dmethvin avatar Aug 05 '15 19:08 dmethvin