download.jqueryui.com icon indicating copy to clipboard operation
download.jqueryui.com copied to clipboard

ThemeRoller: Customizable link color

Open scottgonzalez opened this issue 12 years ago • 8 comments

Currently the jquery ui css overrides the link color specified in your own css. On my project, we need the links to be blue and underlined for accessibility reasons, but the ui css sets it to the same color as the text.

You can override these styles, but in doing so you are creating bug-prone, brittle code.

It'd sure be nice if we could customize the color for plain-text links inside ui widgets using themeroller. That way such hacks could be avoided.

http://bugs.jqueryui.com/ticket/6018

scottgonzalez avatar Oct 10 '12 17:10 scottgonzalez

Hello, I have the same problem. Why was this bug marked as invalid? Best regards, Marc-Etienne

vargenau avatar Jan 30 '13 17:01 vargenau

What are you talking about? This issue is still open.

scottgonzalez avatar Jan 30 '13 17:01 scottgonzalez

Sorry, I was thinking of http://bugs.jqueryui.com/ticket/6018

vargenau avatar Jan 30 '13 17:01 vargenau

@vargenau np. It's closed there, because it's moved here.

rxaviers avatar Jan 30 '13 17:01 rxaviers

Yes, I understand now. I hope it will get fixed. Best regards, Marc-Etienne

vargenau avatar Jan 30 '13 17:01 vargenau

This has been open for 3 years now, are there any plans to do something about it? This is the only part of the css that actually needs touched when you download a theme so it would really be nice if this were added to the ui.

Now since the original poster did not offer a suggestion for what it should look like I will.

  • A separate accordion tab just for links since the color/style should be universal
  • Three color choices for a:link, a:hover, a:visited. (Maybe another for a:active but I personally do not see that as needed, just my opinion though)
  • Size input selection (just like font settings)
  • Font weight selection (just like font settings)
  • Checkbox for underline
  • Another possible suggestion is to make the size/weight/underline options available for each state of the anchor tag.

I think those options should cover most cases of what people would want to customize, if they want to take it even further that is something they should have to go into the css and edit themselves.

Isotab avatar Dec 04 '15 17:12 Isotab

I assume you're referring to the .ui-widget-content a rule? I'm actually not sure why this rule even exists. We should probably just drop it from the theme.

scottgonzalez avatar Dec 04 '15 18:12 scottgonzalez

I agree this does not really make any sense could probably just drop it and double check through all the demos nothing weird happens or gets broken.

arschmitz avatar Dec 05 '15 04:12 arschmitz