Core: Call to resetInternals removed in remote validation callback

[leonardospina]

Hi,

The modification is related to the following issues, which although marked as closed don't seem to be properly fixed: https://github.com/jquery-validation/jquery-validation/issues/12 https://github.com/jquery-validation/jquery-validation/issues/1669 https://github.com/jquery-validation/jquery-validation/issues/1375

From the user point of view the issue is that fields in a form which has at least one field with remote validation will be "unhighlighted" if the remotely validated field has a valid default value (remote validation is successful and any other invalid field is cleared out); Validation error messages are still shown on the interface, but the invalid fields are shown as valid (the CSS class is reset)

Thanks, Leonardo

[Arkni]

Thanks for your contribution! I'll take a look at it as soon as possible!

[newclaus]

Is there anybody alive here?

[leonardospina]

I'd be alive, but I cannot pull it! :-)

[ghost]

@Arkni @Kieran @staabm Any reason for not merging this PR ?

[bytestream]

It needs a test, otherwise we just go round in circles :)

[ghost]

@leonardospina

It needs a test, otherwise we just go round in circles :)

Can you do the test ?

[leonardospina]

Mmmm I should set up a project on purpose, quite hard to find the time (I moved company 2 years ago, that issue was spotted in a previous company project, working with all different technologies now...)

---------------------------------- The worst thing about listening to Iron Maiden for the first time is that you cannot listen to Iron Maiden for the first time ever again.

On Tue, 17 Jan 2023 at 09:54, julien-tschappat @.***> wrote:

@leonardospina https://github.com/leonardospina

It needs a test, otherwise we just go round in circles :)

Can you do the test ?

— Reply to this email directly, view it on GitHub https://github.com/jquery-validation/jquery-validation/pull/2242#issuecomment-1385122740, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVVRA7OG6IQ56UEHQFWII3WSZT4DANCNFSM4GHF2KAA . You are receiving this because you were mentioned.Message ID: @.***>

[ghost]

@leonardospina OK, I'll look if I can do something. But can you give me access to your jquery-validation fork repository ? Otherwise I think I will have to do a new PR

[leonardospina]

@julien-tschappat should be done can you try and access

[ghost]

@bytestream I've added the test. Let me know if something else is required.

FYI : @leonardospina

[bytestream]

Many thanks @julien-tschappat :)

[jansokoly]

Thank you @leonardospina @julien-tschappat @bytestream.

[leonardospina]

My pleasure.