jarle icon indicating copy to clipboard operation
jarle copied to clipboard

[Preview] react-devtools console warning: Module not found: Can't resolve 'holderjs'

Open mbrookes opened this issue 4 years ago • 3 comments

Current Behavior 😯

../node_modules/jarle/esm/Preview.js
Module not found: Can't resolve 'holderjs' in '/Users/mbrookes/Projects/material-ui/node_modules/jarle/esm'
_ _ _
overrideMethod @ VM114144 react_devtools_backend.js:2430
printWarnings @ hot-dev-client.js?647e:126
handleWarnings @ hot-dev-client.js?647e:131
processMessage @ hot-dev-client.js?647e:213
eval @ hot-dev-client.js?647e:54
eval @ eventsource.js?9b42:39
handleMessage @ eventsource.js?9b42:37

Expected Behavior 🤔

No warning

Steps to Reproduce 🕹

  1. Use Jarle in Chrome with react-devtools
  2. Check the console

Context 🔦

Testing Jarle for use in React component documentation, where developers checking the console will not expect to see errors.

mbrookes avatar Jan 30 '21 13:01 mbrookes

Yeah this is do to an optional require that the editor makes that webpack warns about.ineed to see if there is a good way to hint that it's fine it's not found

jquense avatar Jan 30 '21 14:01 jquense

Yeah, I'd traced it that far. I had hoped there might be a way to suppress the warning altogether...

mbrookes avatar Jan 30 '21 15:01 mbrookes

This warning also shows in Vite: image

Does holderjs not need adding to the dependencies?

Adam-Collier avatar Sep 13 '21 11:09 Adam-Collier