Jason Quense

Results 378 comments of Jason Quense

in general for themes that are CSS only (e.g. no new javascript) any bootstrap theme should work

That is true because the SC wrapper adds its own `as` prop. So in the example the StyledFormControl isn't actually rendering a bootstrap component just a plain `select`. I'm not...

This is very cool, glad you are taking it up 💪 I don't have much to say about the code atm, but worth hashing through the API a bit yeah?...

Hey @bpas247 sorry for the silence, a bit short on time but not forgotten about this!

Hi @Rogach thanks for taking the time to send over a PR. While, we definitely appreciate the work, I don't believe we are accepting any more patches to the bs3...

`as` on Button is not really intended for the Link case, you should do it the other way around ``

We test it in Jest, maybe reference our tests to see how you might alter yours? https://github.com/react-bootstrap/react-bootstrap/blob/master/test/NavDropdownSpec.js

have you tried adding a delay after the click? The positioning logic is async i believe

The suggestion is still valid. However, it's not being made because RB doesn't support tree shaking. RB should be tree shakeable. The issue is that tree shaking as an optimization...