heroku_san icon indicating copy to clipboard operation
heroku_san copied to clipboard

heroku_san should support https://git.heroku.com/ repo URIs as a configurable option

Open jikamens opened this issue 9 years ago • 2 comments
trafficstars

Heroku seems to be encouraging people to use https://git.heroku.com/ repo URIs rather than [email protected]: URIs, i.e., https instead of ssh. Heroku_san should at least allow this as an option, if not make it the default.

Note that this would fix #165, a long-standing bug which really deserves a better fix than a workaround buried in the comments of an open issue. Since Heroku now supports and recommends the accounts plugin to the toolbelt, heroku_san should be able to deal with it.

jikamens avatar Dec 28 '15 18:12 jikamens

I agree! I've been unable to work on this fix for months, but maybe today is the day. I have some time off :-)

On Mon, Dec 28, 2015 at 10:44 AM, Jonathan Kamens [email protected] wrote:

Heroku seems to be encouraging people to use https://git.heroku.com/ repo URIs rather than [email protected]: URIs, i.e., https instead of ssh. Heroku_san should at least allow this as an option, if not make it the default.

Note that this would fix #165 https://github.com/fastestforward/heroku_san/issues/165, a long-standing bug which really deserves a better fix than a workaround buried in the comments of an open issue. Since Heroku now supports and recommends the accounts plugin to the toolbelt, heroku_san should be able to deal with it.

— Reply to this email directly or view it on GitHub https://github.com/fastestforward/heroku_san/issues/173.

[email protected] | (808) 722-6142 (c)

kmayer avatar Jan 02 '16 16:01 kmayer

A breaking test would be helpful.

kmayer avatar Mar 12 '16 23:03 kmayer