jpype icon indicating copy to clipboard operation
jpype copied to clipboard

Windows locale

Open Thrameos opened this issue 1 year ago • 2 comments

This is an attempt to make JPype work when there are international characters in the path name. Currently does not appear to make a significant difference because the JVM itself does not support it on the tested system.

Thrameos avatar Feb 24 '24 18:02 Thrameos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.44%. Comparing base (904fc43) to head (2c0420e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
- Coverage   87.45%   87.44%   -0.01%     
==========================================
  Files         113      113              
  Lines       10236    10236              
  Branches     4057     4057              
==========================================
- Hits         8952     8951       -1     
  Misses        692      692              
- Partials      592      593       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 24 '24 18:02 codecov[bot]

@marscher This is meant to address #1111 but as I don't have a system that supports international paths for the JVM I can't really tell if it fixes anything more than moving the failure point. If the international testers do find it to fix the problem, I will complete this PR with the usual changelog entry, ask for a review, etc.

Thrameos avatar Feb 24 '24 18:02 Thrameos

Thanks at lot and sorry for the delay!

marscher avatar Apr 28 '24 23:04 marscher