jpype icon indicating copy to clipboard operation
jpype copied to clipboard

Remove theme overrides from inclusion

Open Thrameos opened this issue 2 years ago • 3 comments

Thrameos avatar May 15 '22 15:05 Thrameos

Codecov Report

Merging #1065 (e5339f6) into master (faa41f7) will increase coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   88.63%   88.66%   +0.02%     
==========================================
  Files         112      112              
  Lines       10235    10235              
  Branches     4012     4012              
==========================================
+ Hits         9072     9075       +3     
+ Misses        703      702       -1     
+ Partials      460      458       -2     
Impacted Files Coverage Δ
native/common/jp_methoddispatch.cpp 87.03% <0.00%> (+0.92%) :arrow_up:
native/common/jp_method.cpp 98.84% <0.00%> (+1.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c710b9e...e5339f6. Read the comment docs.

codecov[bot] avatar May 15 '22 15:05 codecov[bot]

The file in _static/theme_overrides.css should also be removed.

Confirming that in the built docs, there are no use of the only element that that file overrides, namely wy-table-responsive. Grepping the built docs:

$ grep "wy-table-responsive"  ./_build/ -r -l
./_build/html/_static/css/theme.css
./_build/html/_static/js/theme.js
./_build/html/_static/theme_overrides.css

pelson avatar Jul 04 '22 07:07 pelson

Confirming that in the built docs, there are no use of the only element that that file overrides

Actually, I realise that this means very little, since the theme.js file injects table class types, so this override is active. I can't actually observe the behaviour that the override is trying to fix though.

pelson avatar Jul 04 '22 07:07 pelson