jpype
jpype copied to clipboard
Simplify startJVM and support PathLike types for classpath and jvmpath arguments
Closes https://github.com/jpype-project/jpype/issues/529
Codecov Report
Merging #1062 (05a6d6c) into master (1da1101) will increase coverage by
0.02%. The diff coverage is93.02%.
@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
+ Coverage 88.65% 88.68% +0.02%
==========================================
Files 111 111
Lines 10211 10215 +4
Branches 4016 4016
==========================================
+ Hits 9053 9059 +6
+ Misses 699 698 -1
+ Partials 459 458 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| jpype/_core.py | 95.61% <92.50%> (+0.05%) |
:arrow_up: |
| jpype/_classpath.py | 80.95% <100.00%> (+0.46%) |
:arrow_up: |
| native/common/jp_method.cpp | 98.84% <0.00%> (+1.15%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@marscher & @Thrameos, sorry to bother you both (I appreciate you are both busy!). Just wondering if I can request a re-review of this please? It is one of those changes that touches a few things, and would like to avoid getting unnecessary merge-conflicts. It is also a platform from which I would like to build out a few more typing/code-quality improvements.
Thanks for merging. I'm happy to see this in - it is a small change, but makes life so much more pleasant when you have an IDE and static-analysis at your fingertips. :+1:
My pleasure. Thank you for propelling this into the future. :+1: