jpveooys
jpveooys
**Describe the bug** When: - there are certain nested JSX expression within a React Story - dynamic code generation for the docs addon is enabled (the default) - the Storybook...
Currently, accessibility tests are being done using @storybook/addon-storyshots-puppeteer. However, they can now be done using the Storybook test runner: - https://storybook.js.org/blog/automate-accessibility-tests-with-storybook/ - https://storybook.js.org/docs/react/writing-tests/accessibility-testing#automate-accessibility-tests-with-test-runner This has the advantage of being compatible...
Types should be checked in the 'Build & test' workflow to avoid problems like https://github.com/defencedigital/mod-uk-design-system/issues/3417.
There are various axe accessibility checks failing for the ContextMenu component. These relate to missing ARIA roles and possibility incorrect use of `div`s. These aren't being tested currently, as the...
When opening a context menu using the ContextMenu component, it appears in the wrong location briefly. https://user-images.githubusercontent.com/66470099/186116714-caadd1e2-e76f-401a-8485-0caaeb0589c2.mp4
## Related issue #2871 #2872 ## Overview Work in progress PR to migrate DatePicker to react-day-picker v8. ## Link to preview todo ## Reason To resolve various accessibility and keyboard...
Following https://github.com/defencedigital/mod-uk-design-system/issues/2716 we decided that we should migrate from yarn v1 to npm v8. There are currently two external issues blocking this: - https://github.com/npm/cli/issues/4834 - https://github.com/lerna/lerna/issues/2832 (assuming that this affects...
This speeds up Storybook loading time. See https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#using-the-v7-store And https://storybook.js.org/blog/storybook-on-demand-architecture/ To turn on add this to `.storybook/main.js`: ``` framework: '@storybook/react', features: { storyStoreV7: true, }, ```
From @k9dh3zij (in #2841): > When opening the Sheet, can we move focus to the currently selected date? (as in https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/datepicker-dialog.html) The linked example focuses the selected date if one...
When the date picker is in range mode and a second date is being selected (focused) using the keyboard arrow keys, the days between the first and focused date are...