html-to-draftjs icon indicating copy to clipboard operation
html-to-draftjs copied to clipboard

Feature: Within getSafeBodyFromHTML if document is undefined use jsdom

Open michaelkramer opened this issue 7 years ago • 6 comments

I have made these changes, because for my needs I'm converting HTML within the server side creating and storing the draftjs blocks.

michaelkramer avatar Jan 09 '19 19:01 michaelkramer

@michaelkramer All users may not need this, can you plz add a flag to enable/disable it.

jpuri avatar Jan 12 '19 06:01 jpuri

@jpuri Please look this over, I could not get it to build on my computer.

I added some read me docs to it.

thank you

michaelkramer avatar Jan 12 '19 16:01 michaelkramer

The PR has too many code changes :( Can you simplify it and check if environment is node / browser to fix the behaviour.

jpuri avatar Jan 16 '19 10:01 jpuri

Well it took me a while but I cleans up the code. My env formatted all the pages that I did not want to be formatted. @jpuri

michaelkramer avatar Jan 18 '19 00:01 michaelkramer

This does not look good for merge still :(

jpuri avatar Jan 29 '19 07:01 jpuri

What more do you need me to do?

michaelkramer avatar Feb 08 '19 16:02 michaelkramer