JP Simard

Results 706 comments of JP Simard

Bug fixes that break things for people relying on the buggy behavior shouldn't be considered a breaking change IMHO. Not sure if you ended up fixing this as part of...

Ah, I see what the issue is now, and why I did this in the first place. Definitely possible for users to be relying on this behavior.

I'm sorry I don't know if that's possible.

It might. I'd love to see that library expose its functions via SourceKit, which would allow targeting multiple Swift versions of it, much in the way we support multiple SourceKits...

Hi @compnerd, first sorry for the delay (laid off, job search, other priorities, etc). Second, it's fantastic to see SourceKitten working on Windows, massive kudos 🙌. My main point of...

I've cherry-picked and merged many of the commits from this PR in #779. Could you please rebase this PR with the remaining changes and I can add feedback inline? Or...

> Would be happy to open a PR to get this started if the maintainers of this library would be interested in merging it in. I'd be happy to merge...

I think SourceKit in Xcode 14.3 doesn't return a serialized syntax tree anymore. I think you're meant to use the SwiftSyntax library to get that instead.

Thanks for driving all this, @johnfairh!

As I mentioned in the Swift forums thread, SourceKit's API for completions is really counter-intuitive. Maybe asking the folks who work on SourceKit at Apple will lead you to a...