JP Simard

When I enable WMO with Bazel, I see the same improvement as with SwiftPM. I’ll be doing that shortly.

There are 4 SwiftSyntax regressions that we're seeing here: - `return_value_from_void_function` was reporting false positives because of https://github.com/apple/swift-syntax/issues/851. I have a workaround for now so this shouldn't block us. Update:...

All the `operator_usage_whitespace` regressions are caused by https://github.com/apple/swift-syntax/issues/860

With https://github.com/apple/swift-syntax/pull/869 we're down to just a single known regression, which affects only a single file and a single rule in OSSCheck: [/KsApi/GraphAPI.swift:34:39: warning: Syntactic Sugar Violation: Shorthand syntactic sugar...

# 🎉 There are no more known regressions on either performance or correctness 🎉 Still requires https://github.com/apple/swift-syntax/pull/869 before we can point to `apple/swift-syntax@main`, but otherwise we're good! --- That being...

Ugh, no the CocoaPods integration is a huge hack, it just works with binary releases. literally any other installation method works though. Mint, bazel, SwiftPM, Makefile.

Thanks for the PR! I'll review shortly but in the meantime, here's some unused imports that CI flagged: ``` Source/swiftlint/Commands/Common/RulesFilterOptions.swift:2:1: error: Unused Import Violation: All imported modules should be required...

That's why we don't have tests for the CLI target.

Fantastic! To be honest I don't remember the exact reason why we didn't have CLI, it might have been something else that's since been resolved, or maybe I didn't configure...

Yeah so SwiftPM wasn't able to do this until recently: https://github.com/apple/swift-package-manager/issues/4639