Yams icon indicating copy to clipboard operation
Yams copied to clipboard

Swap `sortKeys` bool for `keySort` function

Open kevboh opened this issue 3 years ago • 4 comments

(This is a breaking change, but I can make it non-breaking if preferred. It's just a lot more code repetition if non-breaking.)

This changes the sortKeys option to be a more flexible keySort function. The function defaults to nil—do not sort—but can be anything that sorts Nodes. I ran into an issue where I wanted a custom sort on a mapping.

kevboh avatar Apr 05 '21 02:04 kevboh

Thanks for the PR! Could you please rebase your commits on top of main? That should fix the failing CMake CI jobs.

jpsim avatar Apr 07 '21 16:04 jpsim

@jpsim this has been rebased. Thanks for taking a look!

kevboh avatar Apr 11 '21 11:04 kevboh

@jpsim let me know if anything else is required here.

kevboh avatar Apr 17 '21 13:04 kevboh

Hi, is this still mergeable? If so I'd love to merge it!

kevboh avatar Jun 20 '21 12:06 kevboh