SourceKitten icon indicating copy to clipboard operation
SourceKitten copied to clipboard

Allow Swift Argument Parser versions from 1.2.1 to 2.0.0

Open tonyarnold opened this issue 2 years ago • 8 comments

This lower version number is preventing packages from using SwiftLint and the Swift OpenAPI Generator in the same package.

tonyarnold avatar Dec 13 '23 22:12 tonyarnold

While I'm doing this — would you be willing to consider changing this dependency from upToNextMinor to upToNextMajor?

tonyarnold avatar Dec 13 '23 22:12 tonyarnold

While I'm doing this — would you be willing to consider changing this dependency from upToNextMinor to upToNextMajor?

Yes, let's do that but revert back to 1.2 so that if other packages are depending on 1.2.x this change doesn't break them.

jpsim avatar Dec 14 '23 03:12 jpsim

Don't worry about the Bazel test failures, there's been some changes to Bazel that I should adjust for.

jpsim avatar Dec 14 '23 03:12 jpsim

No problems, I'll do it now. Did you want me to do the same for SWXMLHash?

tonyarnold avatar Dec 14 '23 03:12 tonyarnold

Yes please! 🙏

jpsim avatar Dec 14 '23 04:12 jpsim

Done in 91d9cd7174081138805e0ba848ec634ba4bfb406.

I'll do the same for SwiftLint once there's a tagged release of SourceKitten with these changes in it.

Thanks, JP!

tonyarnold avatar Dec 14 '23 04:12 tonyarnold

Can this be merged? Together with a new release, SwiftLint could use 1.3.0 of Swift Argument Parser.

SimplyDanny avatar Feb 05 '24 22:02 SimplyDanny

Hello @SimplyDanny, I wish to have this update available as I cannot use both OpenAPI and SwiftLint. Is there anything missing that I can help you with if needed?

Sparklydust avatar Apr 12 '24 12:04 Sparklydust

I need this as well 🙏🏻

revolter avatar May 05 '24 15:05 revolter

Ill merge and look into the CI failures async.

jpsim avatar May 05 '24 15:05 jpsim

Thank you very much 🙏🏻 Hopefully you have time to push a new release as well, containing this change.

revolter avatar May 05 '24 16:05 revolter

0.35.0 was pushed with these changes: https://github.com/jpsim/SourceKitten/releases/tag/0.35.0

jpsim avatar May 05 '24 17:05 jpsim

Continued in https://github.com/realm/SwiftLint/pull/5562

revolter avatar May 05 '24 19:05 revolter