SourceKitten icon indicating copy to clipboard operation
SourceKitten copied to clipboard

Published 20 hours ago • verified publisher icon jpsim

Interest in returning JSON from send?

Open RLovelett opened this issue 8 years ago • 3 comments

I've created a fork of SourceKitten so that I can return JSON (read: Any) from failableSend(). I'm wondering what interest the project maintainers would have for accepting such a patch/change?

This is the change I'm specifically talking about. Obviously I'd be willing to write some tests and/or rename the method. This was just quick-n-dirty to see what such a method would look like.

RLovelett avatar Nov 25 '16 20:11 RLovelett

Interesting... I wonder if this would net us some performance enhancements, by sending JSON rather than XPC objects between SourceKitten and SourceKit...

jpsim avatar Nov 25 '16 23:11 jpsim

Just curious why you closed this @RLovelett? Still seems like an approach worth prototyping and benchmarking...

jpsim avatar Mar 20 '17 18:03 jpsim

I think you are right it is. I just kinda lost interest in doing it myself and I was afraid this was becoming stale/spam in your issue tracker.

If you want it to remain open. Obviously I have no problem with that.

RLovelett avatar Mar 31 '17 00:03 RLovelett