bcrypt module not compatible with nodejs12.x

[liwani]

AWS discontinued support for nodejs8.10. I changed the code to nodejs12.x based on previous commit that updated project nodejs version. This caused an error with bcrypt module:

"errorMessage": "The module '/var/task/node_modules/bcrypt/lib/binding/bcrypt_lib.node'\nwas compiled against a different Node.js version using\nNODE_MODULE_VERSION 57. This version of Node.js requires\nNODE_MODULE_VERSION 72. Please try re-compiling or re-installing\nthe module (for instance, using `npm rebuild` or `npm install`)."

I tried to replace bcrypt in lambda-login.zip with the latest version but it didn't help. Unfortunately, I don't know enough about nodejs deployment to quickly resolve it. I was wondering if you are planning to update to latest supported nodejs version?

[jpsim]

No I'm not planning on making changes to this project in the near future.

[liwani]

Thanks Andrew. I cloned your branch and finally was able to successfully deploy the project in AWS!

On Wed, Jan 22, 2020 at 1:17 PM A Stevens [email protected] wrote:

Actually I seemed to have fixed it -Site-Builder was built later in the cloudformation process, after the cloudfront deployment. I'll submit a change shortly that should make it deployable.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jpsim/AWSPics/issues/28?email_source=notifications&email_token=AM2NQPY4T6I5CUO6FLQXM53Q7CETFA5CNFSM4KEPFWH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJUSQUA#issuecomment-577316944, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM2NQP7EX4CUABESZIKMY3DQ7CETFANCNFSM4KEPFWHQ .

[agstevens]

I fixed the bcrypt EOL in https://github.com/jpsim/AWSPics/pull/49 Now it uses bcrypt 5.0.1+ instead of bcrypt 2.0.1 which had reached End of Life.

[agstevens]

Marking closed with latest PR https://github.com/jpsim/AWSPics/pull/49