NNEDI3
NNEDI3 copied to clipboard
jpsdr
Allow building with wineg++
Hello. I will not merge the PR, some of it break my VS build. "aligned_alloc" doesn't exist, and "_aligned_free" is mandatory when an "_aligned_malloc" is made, you must use it, and not just "free". Also, i think "strncasecmp" doesn't exist (with VS). It also involve changes in the avisynth include files, made changes in the avisynth include files validate with avs devs. As when i update these files i just replace them with the new version i got from avs+ github. Don't realy want to put this kind of changes. My advice : create your own github version cloning this, and then apply your patch.
No problem at all @jpsdr. I didn't open PR with any expectation of merger. It just helps users see what patches exist if they search Google, that's all. :-)
@ctrlcctrlv You can do better and wrap compiler-specific code into preprocessor's directive, so it will be ignored for visual studio. That way it definitely will not harm the maintainer's experience with VS. You still have to provide another way (meson, cmake or make) to compile nnedi3 plugin with your additions (setting your directive with -D to enable it).
@DJATOM I have no way to test on VS+MSVC, sorry, which is why I didn't already do that.