node-github-download icon indicating copy to clipboard operation
node-github-download copied to clipboard

Published 20 hours ago • verified publisher icon jprichardson

bug-fix: download files across devices now works

Open itsthatguy opened this issue 10 years ago • 2 comments

fs.rename does not work across devices.

  • Implementing mv to replace fs.rename.

itsthatguy avatar Jul 20 '14 16:07 itsthatguy

A few things:

  1. Please change the require alignment back to the way it was.
  2. Please remove the version bump.
  3. Please remove the mv dependency and use fs.move from fs-extra. (fs.move is mv)

That should do it. Thanks.

jprichardson avatar Jul 22 '14 19:07 jprichardson

re: 1. Feel free to change that back, I'm not in an ideal environment to make that change (mobile)

itsthatguy avatar Jul 24 '14 06:07 itsthatguy