node-fs-extra icon indicating copy to clipboard operation
node-fs-extra copied to clipboard

Published 20 hours ago • verified publisher icon jprichardson

Port copy fix from Node.js core

Open RyanZim opened this issue 2 years ago • 3 comments

Just opening an issue for https://github.com/nodejs/node/pull/39372#discussion_r670744165 so this doesn't get forgotten.

RyanZim avatar Aug 10 '21 13:08 RyanZim

@manidlou FYI, will be working on pushing a new major release in the coming days with ESM support (refs https://github.com/jprichardson/node-fs-extra/issues/746#issuecomment-923250293); any chance you could tackle this soon?

RyanZim avatar Sep 21 '21 17:09 RyanZim

It seems not difficult to support esm/cjs at the same time through the build tool, why not do this? esm only can cause other problems. For example, some packages only support cjs, and some packages only support esm. This is very annoying. I can only package all dependencies into the bundle through the build tool.

rxliuli avatar Sep 25 '21 06:09 rxliuli

@rxliuli We are planning to support both CJS and ESM; due to some special considerations, we can't just use an out of the box solution. See the issue for more details.

RyanZim avatar Sep 25 '21 12:09 RyanZim

There's a real bug here, but I'm not sure if @bcoe fixed it correctly; see https://github.com/nodejs/node/pull/39372#discussion_r1001179295

RyanZim avatar Oct 20 '22 22:10 RyanZim