Jimmy Praet

How to represent input validation issues that relate to multiple parameters?

14

In the deprecated [InvalidParamProblem](https://github.com/belgif/openapi-problem/blob/7c16aea3777d3b17fc08d95d3d24b4095f4d51c4/src/main/openapi/problem/v1/problem-v1.yaml#L64-L75), it was possible to reference multiple [invalidParams](https://github.com/belgif/openapi-problem/blob/7c16aea3777d3b17fc08d95d3d24b4095f4d51c4/src/main/openapi/problem/v1/problem-v1.yaml#L76-L93). In the new [InputValidationProblem](https://github.com/belgif/openapi-problem/blob/7c16aea3777d3b17fc08d95d3d24b4095f4d51c4/src/main/openapi/problem/v1/problem-v1.yaml#L94-L102) you can reference multiple [issues](https://github.com/belgif/openapi-problem/blob/7c16aea3777d3b17fc08d95d3d24b4095f4d51c4/src/main/openapi/problem/v1/problem-v1.yaml#L139-L154), but each issue can only reference a single parameter (in,...

HTTP headers must be handled in case-insensitive manner

3

According to the [spec](https://www.rfc-editor.org/rfc/rfc7230#section-3.2), HTTP headers are case-insensitive. The section REST guide [section](https://www.belgif.be/specification/rest/api-guide/#reserved-HTTP-headers) that covers HTTP headers should probably mention this? Some middleware or tools can alter the casing of...

Using InputValidationProblem for urn:problem-type:belgif:missingPermission

1

https://www.belgif.be/specification/rest/api-guide/#missing-permission sometimes relates to usage of specific input parameters. Currently it is not specifically mentioned in the rest-guide that a urn:problem-type:belgif:missingPermission may contain "issues" property (so using InputValidationProblem type instead...

create belgif-openapi-bom

1

A [Maven BOM](https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#bill-of-materials-bom-poms) could be created to keep the versions of the belgif-openapi types in synch. It can be created here: https://github.com/belgif/openapi-bom Some additional thought is required about the versioning...

Fixes #17875 ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING.md). - [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details...

### Description  In the database, the field is set correctly to "sha1", but in the API response it is "". ### Gitea Version 1.22.0 ### Can you reproduce the...

Incorrect API response for repositories without avatar

1

### Description For repositories without an avatar, we now get this in the API response: `"avatar_url": "https://demo.gitea.com/"` In 1.21 this was `"avatar_url": ""` ### Gitea Version 1.23.0+dev-151-gc93cbc991e ### Can you...

Warnings in successful response

7

This topic has already been briefly touched upon in https://github.com/belgif/rest-guide/issues/74. How can we model non-blocking warnings that are returned in a successful API response? A [Warning](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Warning) HTTP header exists, but...

Standardized Belgif problem type(s) for 409 Conflict

3

The Belgif REST Guidelines make various references to HTTP 409 Conflict: * optimistic locking in [PUT](https://www.belgif.be/specification/rest/api-guide/#document-full-update) / [PATCH](https://www.belgif.be/specification/rest/api-guide/#document-partial-update) * constraint violation on [DELETE](https://www.belgif.be/specification/rest/api-guide/#remove-document) * duplicate key on [POST](https://www.belgif.be/specification/rest/api-guide/#create-resource) But no...

Fixes #19188 and reverts #18724. Generated builder classes should not contain bean validation annotations. They are unnecessary and cause problems on some Java EE servers (e.g. JBoss EAP). ### PR...