jPOS-EE icon indicating copy to clipboard operation
jPOS-EE copied to clipboard

Implement TriggerListener

Open chhil opened this issue 6 years ago • 5 comments

At times its possible trigger doesn't fire (quartz calls it mis-fire)and we need to log it else we may just not know when a job isn't performed. Mis-fire handling instructions need to be provided at trigger creation time (withMisfireHandlingInstructionFireAndProceed). Also helpful to log when the trigger is fired and completed(part of TriggerListener implementation) along with info when it will get triggered again.

chhil avatar Jul 05 '18 05:07 chhil

You should add scheduler.getListenerManager().addTriggerListener(this); to register the trigger to the scheduler, otherwise the methods are not called.

aVolpe avatar Dec 18 '20 14:12 aVolpe

You should add scheduler.getListenerManager().addTriggerListener(this); to register the trigger to the scheduler, otherwise the methods are not called.

You are correct, for some reason it did not get added in this PR (most likely due to me running on older versions of jpos and copy pasting the code directy into github editor). . I have this running in prod code.

https://github.com/jpos/jPOS-EE/compare/master...chhil:patch-6

chhil avatar Dec 19 '20 03:12 chhil

Your patch-6 wasn't added to this PR @chhil - can you force push it?

ar avatar Dec 19 '20 22:12 ar

What do I need to do to force push?

chhil avatar Dec 20 '20 01:12 chhil

I believe you need to cherry-pick your patch-6 change (d051d8e5) into your patch-11, then push -f your patch-11.

ar avatar Dec 20 '20 16:12 ar