psst icon indicating copy to clipboard operation
psst copied to clipboard

Preferences: Hide password

Open shiftgeist opened this issue 3 years ago • 4 comments

The password is currently shown in clear text. I think the user is more used to the characters being replaced by dots.

shiftgeist avatar Mar 14 '21 17:03 shiftgeist

~~@jpochyla Is the problem that Druid doesn't have corresponding password textbox yet? If you simply don't have time, would you take a PR for that?~~ P.S. Thanks for building and working on psst. Worked like charm on my MBP.

Edit: Yes, it's a problem in Druid for now. Found corresponding issue and WIP PR in Druid.

yerke avatar Aug 20 '21 21:08 yerke

Looks like the PR for Druid was closed as the author wasn't aware of anyone who wanted this feature (see: https://github.com/linebender/druid/pull/1839#issuecomment-961144628). I wonder if we showed a proof of concept of psst using this PR that would help things move along.

restitux avatar Dec 31 '21 21:12 restitux

POC of psst using TexBox::protected from jpochyla/druid/psst rebased on the PR branch available here: https://github.com/restitux/psst. It's working correctly for me on Linux. I cannot test other platforms. If others could test, that would be great!

restitux avatar Dec 31 '21 23:12 restitux

POC of psst using TexBox::protected from jpochyla/druid/psst rebased on the PR branch available here: https://github.com/restitux/psst. It's working correctly for me on Linux. I cannot test other platforms. If others could test, that would be great!

Hi @restitux trying to run the fix on Windows but am getting:

error: -Csplit-debuginfo=unpacked is unstable on this platform error: could not compile cfg-if due to previous error

when compiling. Does the change require nightly rust? I have the latest version of the stable rust toolchain (rustc 1.65.0).

MrBeeMovie avatar Dec 05 '22 16:12 MrBeeMovie