Jeffrey Newman
Jeffrey Newman
There may be a hidden math error in some scheduling models: generally, any model where the is a shift term that is the square of a time period value (start...
By default when creating subprocesses, windows and macOS “spawn” new processes, while on Linux you “fork”. https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods Spawn is slow, but makes a new clean python instance with nothing preloaded....
This PR supercedes all other sharrow PR's, and contains a complete and integrated implementation of all Phase 7 tasks. Published (draft) documentation is here: https://camsys.github.io/activitysim/feature-sharrow-tt
A wide variety of updates have been made in the Sharrow PR, including core enhancements that change how ActivitySim work, and ancillary enhancements that add non-core features that are convenient...
as reported by @jfdman Trip mode choice for trips on at-work subtours aren’t being estimated.
In the MTC model implementation, there is an [expression](https://github.com/ActivitySim/activitysim/blob/v1.0.4/activitysim/examples/example_mtc/configs/tour_scheduling_work.csv#L36) `@(df.tour_count>1) & (df.tour_num == 1) & _adjacent_window_before` The term `_adjacent_window_before` is a temporary value that is an integer giving the size...
In the `choose_intermediate_trip_purpose` function, there is an `iloc` assignment [here](https://github.com/ActivitySim/activitysim/blob/1e4ffc5cdd745c183b2b50385e457c8cfaa6c18d/activitysim/abm/models/trip_purpose.py#L74) that now triggers a pandas FutureWarning. This breaks our tests.
In the prototype_sandag_crossborder, the reproducibility is unstable dependent on the number of processes used for the run. The current model only has a single regression test case, running the model...
As implemented, the estimation example for non-mandatory tour frequency included a [short cut](https://github.com/ActivitySim/activitysim/blob/f1891430d2222b8be8212de1cef498bd75ac66b2/activitysim/estimation/larch/nonmand_tour_freq.py#L88) to limit the number of unique parameters to be estimated for each person type. This was a...
As reported by @jfdman It appears that the coefficients for 3-person households and 4-person households are not being added to the right utility equations in estimation mode. These are the...