salt-ds
salt-ds copied to clipboard
Dialog size implementation is wrong between code and doc
Package name(s)
Website / Documentation
Package version(s)
No response
Description
Currently, what's in code is doing different than what documentation is saying (e.g. medium and large dialog does not go to full screen when xs breakpoint).
https://github.com/jpmorganchase/salt-ds/blob/e8d923ce43d681954f54760a60b70bfa9582ed6c/packages/core/src/dialog/Dialog.css#L54-L127
Size table (width) and Size table (height) is not formatted correctly
The column headers for the Height table read 'width' instead of 'height'.
https://www.saltdesignsystem.com/salt/components/dialog/examples#sizes
Steps to reproduce
No response
Expected behavior
No response
Operating system
- [ ] macOS
- [ ] Windows
- [ ] Linux
- [ ] iOS
- [ ] Android
Browser
- [ ] Chrome
- [ ] Safari
- [ ] Firefox
- [ ] Edge
Are you a JPMorgan Chase & Co. employee?
- [X] I am an employee of JPMorgan Chase & Co.