salt-ds icon indicating copy to clipboard operation
salt-ds copied to clipboard

Published 20 hours ago • verified publisher icon jpmorganchase

Fix Dialog background scroll

Open liamsms opened this issue 7 months ago • 3 comments

Closes #3906

  • Sets the root overflow to 'hidden' to prevent background scrolling while the Dialog is open, same approach as MUI.
  • Scrolling within the Dialog still works as expected.
  • Moved the cleanup callback to a new useEffect with no dependencies to prevent a race condition where the overflow style was sometimes not removed.
  • Tested on Chrome/Windows.

liamsms avatar Jul 29 '24 20:07 liamsms