salt-ds icon indicating copy to clipboard operation
salt-ds copied to clipboard

Navigation pattern example

Open lilyvc opened this issue 10 months ago • 5 comments

Adds an example of Navigation layout to storybook

lilyvc avatar Apr 24 '24 17:04 lilyvc

⚠️ No Changeset found

Latest commit: 2ea2a4dea5c187144808ce4c35ffe59639f513e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 24 '24 17:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 8:10am

vercel[bot] avatar Apr 24 '24 17:04 vercel[bot]

Storybook Preview Link https://9b85d8d1.saltdesignsystem-storybook.pages.dev

github-actions[bot] avatar Apr 24 '24 17:04 github-actions[bot]

Need something to show best practice of small viewport? This could be a good place to think how to reuse other pattern code

There's no guidance on the pattern page about small viewport, so I'm actually not sure of the approach if you have a sidebar and vertical nav and it's mobile. This could be follow up work, this is more just to catch up the examples to the patterns page.

lilyvc avatar Apr 26 '24 11:04 lilyvc

This could be follow up work, this is more just to catch up the examples to the patterns page.

OK, created #3344

origami-z avatar Apr 30 '24 10:04 origami-z